modify anything instead of only inject CSS #39

New Issue

koalp · 2021-05-13T20:39:14+02:00

koalp commented

2021-05-13 20:39:14 +02:00

Currently, it is only possible to add styles, without the media attribute.

It may be nice to be able to inject html everywhere based on selector, and/or to have more control on injected styles (media attribute).

It could also be nice to modify anything

possibilities

Different functions for each type of injection

config
.styles_to_add(&[("print", "body {margin: 0%}")]
.html_children(…)

One function to inject all, with enum and/or trait


trait Inject {
	fn injection_string(&self) -> String;
    
    fn html_position(&self) -> Position;
}

enum Injection {
	BasicStyle(String),
	Style {
    	media: String,
        style: String,
    },
    HtmlChild {
    	parent: String
        html: String
    },
}

impl Inject for Injection {
	…
}

fn main() {
    config
    .inject(Injection::BasicStyle("body {margin: 0%}"")
    .inject(Injection::HtmlChild{…})
}

For edition, it could be nice to have trait for editing html.

impl Edit for Editing {
	…
}

This trait could be implemented by Inject.

previous issue

~~For some newspaper (courrier international), the html given without javascript is very bad (no margin)~~

~~It would be nice to be able to inject CSS at the end of the head to re-style.~~

~~It could be the occasion to rework the self_contained_html function to have a struct as parameter.~~

Currently, it is only possible to add styles, without the media attribute. It may be nice to be able to inject html everywhere based on selector, and/or to have more control on injected styles (media attribute). It could also be nice to modify anything ### possibilities Different functions for each type of injection ```rust config .styles_to_add(&[("print", "body {margin: 0%}")] .html_children(…) ``` One function to inject all, with enum and/or trait ```rust trait Inject { fn injection_string(&self) -> String; fn html_position(&self) -> Position; } enum Injection { BasicStyle(String), Style { media: String, style: String, }, HtmlChild { parent: String html: String }, } impl Inject for Injection { … } fn main() { config .inject(Injection::BasicStyle("body {margin: 0%}"") .inject(Injection::HtmlChild{…}) } ``` For edition, it could be nice to have trait for editing html. ```rust impl Edit for Editing { … } ``` This trait could be implemented by Inject. ### previous issue ~~For some newspaper (courrier international), the html given without javascript is very bad (no margin)~~ ~~It would be nice to be able to inject CSS at the end of the head to re-style.~~ ~~It could be the occasion to rework the `self_contained_html` function to have a struct as parameter.~~

koalp added the

labels 2021-05-13 20:39:14 +02:00

koalp added this to the v0.1.0 - multiple newspaper, html only, chatbot milestone 2021-05-13 20:39:23 +02:00

koalp modified the milestone from v0.1.0 - multiple newspaper, html only, chatbot to v0.1.1 - multiple bug resolution and enhancements

2021-05-13 20:44:38 +02:00

koalp modified the milestone from v0.1.1 - multiple bug resolution and enhancements to v0.1.0 - multiple newspaper, html only, chatbot

2021-05-13 20:44:41 +02:00

koalp added this to the 10 may - 21 may 2021 project 2021-05-13 20:44:45 +02:00

koalp added the

status

accepted

label 2021-05-19 04:09:59 +02:00

koalp commented

2021-05-19 04:10:48 +02:00

This features have been added but has no usecase for now. However, it could be useful to be able to inject anything.

It may be removed or reworked, so this issue will be keeped open, and have been modified.

This features have been added but has no usecase for now. However, it could be useful to be able to inject anything. It may be removed or reworked, so this issue will be keeped open, and have been modified.

koalp removed the

status

review_needed

label 2021-05-19 04:11:19 +02:00

koalp added

and removed

labels 2021-05-19 04:12:29 +02:00

koalp changed title from ~~inject CSS~~ to inject anything istead of CSS