builder for Config #42

New Issue

koalp · 2021-05-20T02:15:45+02:00

koalp commented

2021-05-20 02:15:45 +02:00

It would be nice to have a builder for self_contained_html config.

It could be used with something like

self_contained_html::config()
    .downloader(…) // mandatory
    .base_url(…)   // mandatory
    .elements_to_remove(&[…,…])
    .inject(…)
    .run(my_html_string)

What could also be nice is to use a trait for each builder function argument. It could allow to provide free &[T] trait implementation if trait is implemented for T.

It would add complexity, but it could make it easier to refactor, or to publicly expose.

question is there a better naming than self_contained::config() ?
question if using traits for arguments, what functions should the trait provide ? (and how would it be compatible with the function refactor)

It would be nice to have a builder for self_contained_html config. It could be used with something like ```rust self_contained_html::config() .downloader(…) // mandatory .base_url(…) // mandatory .elements_to_remove(&[…,…]) .inject(…) .run(my_html_string) ``` What could also be nice is to use a trait for each builder function argument. It could allow to provide free `&[T]` trait implementation if trait is implemented for `T`. It would add complexity, but it could make it easier to refactor, or to publicly expose. **question** is there a better naming than `self_contained::config()` ? **question** if using traits for arguments, what functions should the trait provide ? (and how would it be compatible with the function refactor)

koalp added this to the v0.x.x - before stabilization milestone 2021-05-20 02:15:45 +02:00

koalp added the

labels 2021-05-20 02:15:45 +02:00

koalp self-assigned this 2021-05-20 02:15:45 +02:00

Sign in to join this conversation.