Use a struct with a trait rather than several arguments in self_contained_html #3

New Issue

koalp · 2021-04-09T15:51:08+02:00

koalp commented

2021-04-09 15:51:08 +02:00

Currently, the self_contained_html takes two configuration arguments which are downloader, a function to download documents, and base_url, the base url for relative links.

pub fn self_contained_html<S: AsRef<str>>(
    html: S,
    downloader: &dyn Fn(Url) -> Option<String>,
    base_url: &Url,
) -> String {

It would maybe be better to require one config structure with a trait, as it would allow to reduce argument numbers as well as clarifying the function role.

It would also allow to provide a default downloader (¿rename to download ?) function, and write helpers function for different format (images, css) directly in the trait.

Currently, the self_contained_html takes two configuration arguments which are `downloader`, a function to download documents, and base_url, the base url for relative links. ```rust pub fn self_contained_html<S: AsRef<str>>( html: S, downloader: &dyn Fn(Url) -> Option<String>, base_url: &Url, ) -> String { ``` It would maybe be better to require one config structure with a trait, as it would allow to reduce argument numbers as well as clarifying the function role. It would also allow to provide a default `downloader` (¿rename to `download` ?) function, and write helpers function for different format (images, css) directly in the trait.

koalp added the

labels 2021-04-09 15:51:08 +02:00

koalp referenced a pull request that will close this issue

2021-04-23 22:23:57 +02:00

Retrieval for one newspaper #4

koalp added

status

accepted