embeded iframe stays on the page #21

New Issue

koalp · 2021-04-30T18:55:37+02:00

koalp commented

2021-04-30 18:55:37 +02:00

Description

Embeded iframes are not removed by the html self-content

Steps to reproduce

Download from https://www.mediapart.fr/journal/france/290421/violences-sexuelles-plusieurs-femmes-accusent-eric-zemmour
Open the file

Expected behavior

The downloaded html do not sideload external content

Discussion

Html

What to do with iframes ? The iframes may contain useful content. As an example, on this page the external content is youtube links.

Deleting is the easy way and could be the default. Another sane default could be to replace the iframe by the url.

Later, iframe handlers based on the url could be added, but this would add a lot of maintainance (for example each time youtube changes it's api/the library used is updated).

Or should iframes be keeped to avoid adding to users ? It could be configurable but it could lead to too configuration options, which could confuse user. In case of an option, I think that an opiniated default should be chosen.

Article format

What should we do (by default) with iframes in the article format ?

Several options :

Keep links in metadata as external links
Keep links in the article body to keep the place they were originally inserted in (how should they be stored)
Drop all

The first Article may drop them and be refined later as it is simpler to consider articles as only text and images.

## Description Embeded iframes are not removed by the html self-content ## Steps to reproduce 1. Download from https://www.mediapart.fr/journal/france/290421/violences-sexuelles-plusieurs-femmes-accusent-eric-zemmour 2. Open the file ## Expected behavior The downloaded html do not sideload external content ## Discussion ### Html What to do with iframes ? The iframes may contain useful content. As an example, on this page the external content is youtube links. Deleting is the easy way and could be the default. Another sane default could be to replace the iframe by the url. Later, iframe handlers based on the url could be added, but this would add a lot of maintainance (for example each time youtube changes it's api/the library used is updated). **Or** should iframes be keeped to avoid adding to users ? It could be configurable but it could lead to too configuration options, which could confuse user. In case of an option, I think that an opiniated default should be chosen. ### Article format What should we do (by default) with iframes in the article format ? Several options : - Keep links in metadata as external links - Keep links in the article body to keep the place they were originally inserted in (how should they be stored) - Drop all The first `Article` may drop them and be refined later as it is simpler to consider articles as only text and images.

koalp added the

labels 2021-04-30 18:55:37 +02:00

koalp added this to the v0.x.x - before stabilization milestone 2021-04-30 18:55:45 +02:00

koalp modified the milestone from v0.x.x - before stabilization to v0.1.1 - multiple bug resolution and enhancements

2021-05-08 02:59:29 +02:00

koalp added this to the 10 may - 21 may 2021 project 2021-05-13 20:43:47 +02:00